scottyaslan commented on code in PR #8804:
URL: https://github.com/apache/nifi/pull/8804#discussion_r1607343193
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/settings/feature/settings.component.html:
##########
@@ -35,7 +35,7 @@ <h3 class="primary-color">NiFi Settings</h3>
}
</nav>
</div>
- <div class="pt-4 flex-1">
+ <div class="pt-5 flex-1">
Review Comment:
This is actually consistent for all pages with tabs. Each of them receive
`1.25rem` of padding before the first form element is displayed. For cases like
the General tab here or the Summary tables this padding seems comfortable:
<img width="1315" alt="Screenshot 2024-05-20 at 5 50 22 PM"
src="https://github.com/apache/nifi/assets/6797571/5ed8bdb2-9f39-4d61-aa9b-64375d519647";>
<img width="1315" alt="Screenshot 2024-05-20 at 6 01 27 PM"
src="https://github.com/apache/nifi/assets/6797571/c221e6b8-0d8d-4f33-836a-4f26c419541a";>
But for the Management Controller Services, Reporting Tasks, Flow Analysis
Rules, Registry Clients, and Parameter Providers tabs at appears there is more
space:
<img width="1312" alt="Screenshot 2024-05-20 at 5 50 04 PM"
src="https://github.com/apache/nifi/assets/6797571/af8b94bf-1bc4-4680-8d7d-92b707eb7664";>
but really this is an optical illusion. If we look more closely we can see
that the "Create" mat-icon button on the top right of the tables in each of
these views is directly beneath the padding of the tabs:
<img width="1318" alt="Screenshot 2024-05-20 at 5 54 46 PM"
src="https://github.com/apache/nifi/assets/6797571/5e9fc01a-16cb-40ff-b131-d0f702b8d790";>
<img width="1315" alt="Screenshot 2024-05-20 at 5 49 48 PM"
src="https://github.com/apache/nifi/assets/6797571/ea60105a-5757-4b00-ae9c-670cbafc00ff";>
I am happy to discuss options here...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
