szaszm commented on code in PR #1792:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1792#discussion_r1627977636
##########
libminifi/include/core/ProcessGroup.h:
##########
@@ -217,6 +217,9 @@ class ProcessGroup : public CoreComponent {
void verify() const;
+ void setParameterContextName(const std::string &name);
+ std::string getParameterContextName() const;
+
Review Comment:
I think this doesn't need the extra indirection. The config parser can look
up the parameter context, and store a pointer to it here, in the process group.
What do you think? Instead of ParameterContextName, we would work with
ParameterContext directly.
##########
libminifi/include/core/ConfigurableComponent.h:
##########
@@ -136,6 +136,8 @@ class ConfigurableComponent {
*/
bool getDynamicProperty(const std::string& name, std::string &value) const;
+ bool getDynamicProperty(const std::string& name, core::Property &item) const;
Review Comment:
What's the purpose of this overload?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
