szaszm commented on code in PR #1792:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1792#discussion_r1670609030
##########
libminifi/include/core/FlowConfiguration.h:
##########
@@ -134,6 +135,7 @@ class FlowConfiguration : public CoreComponent {
utils::ChecksumCalculator& getChecksumCalculator() { return
checksum_calculator_; }
protected:
+ std::unordered_map<std::string, std::unique_ptr<ParameterContext>>
parameter_contexts_;
Review Comment:
We could make this `gsl::not_null`, and not even store null contexts if they
are even possible. And just give stronger guarantees to any code that uses this
member.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
