lordgamez commented on code in PR #1792:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1792#discussion_r1668807387
##########
libminifi/include/core/ProcessGroup.h:
##########
@@ -217,6 +217,9 @@ class ProcessGroup : public CoreComponent {
void verify() const;
+ void setParameterContextName(const std::string &name);
+ std::string getParameterContextName() const;
+
Review Comment:
Good idea, updated in 7404acec9914456ec059be5b109e09d6c8dff9d2
##########
libminifi/src/core/flow/StructuredConfiguration.cpp:
##########
@@ -799,6 +862,19 @@ void StructuredConfiguration::parsePorts(const flow::Node&
node, core::ProcessGr
}
}
+void StructuredConfiguration::parseParameterContextName(const flow::Node&
node, core::ProcessGroup* parent) {
+ if (!parent) {
+ logger_->log_error("parseParameterContextName: no parent group was
provided");
+ return;
+ }
Review Comment:
Updated in 7404acec9914456ec059be5b109e09d6c8dff9d2
##########
libminifi/include/core/ParameterContext.h:
##########
@@ -0,0 +1,61 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#pragma once
+
+#include <string>
+#include <unordered_set>
+#include <optional>
+
+#include "Core.h"
+
+namespace org::apache::nifi::minifi::core {
+
+class ParameterException : public std::runtime_error {
Review Comment:
Updated in 7404acec9914456ec059be5b109e09d6c8dff9d2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
