lordgamez commented on PR #1793:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1793#issuecomment-2331896597
> @lordgamez thanks for looking into the HTTP related CURL tests. Yeah for
the **conanfile.py** file, we use **libcurl** version **8.6.0** and for
**standalone CMake**, we use **8.4.0**. It could be a **libcurl** version
difference, but we can also consider in **standalone CMake**, we configure
**libcurl** in **cmake/BundledLibcURL.cmake** before being built:
>
> ```shell
> "-DCMAKE_INSTALL_PREFIX=${BINARY_DIR}/thirdparty/curl-install"
> -DBUILD_CURL_EXE=OFF
> -DBUILD_TESTING=OFF
> -DBUILD_SHARED_LIBS=OFF
> -DHTTP_ONLY=ON
> -DCURL_CA_PATH=none
> -DCURL_USE_LIBSSH2=OFF
> -DUSE_LIBIDN2=OFF
> -DCURL_USE_LIBPSL=OFF
> -DCURL_USE_OPENSSL=ON
> ```
>
> Whereas for **conan**, we install that **libcurl** prebuilt library using
the default configs. If we do want to get closer to configuring conan's
**libcurl** like we do for the standalone CMake, we can either make some
updates to our **conanfile.py** or make updates to **libcurl's** conan recipe.
Heres **libcurl's** conan recipe from conan-center-index repo and line 566 that
is an example of how they set "**BUILD_CURL_EXE**" to False aka OFF:
>
> *
https://github.com/conan-io/conan-center-index/blob/master/recipes/libcurl/all/conanfile.py#L566
>
> Do you think we see a difference in HTTP performance because of these
configurations to **libcurl** build?
Hi @james94, I think both options are plausible to cause the difference in
the test run, we should try to build from source with the newer version and
with the default build options too and see if one of those builds behaves the
same way as the conan build, and maybe check out the logs what causes this
behavior. Maybe some timeouts are different, or some additional checks are
added in the newer version, not sure. Unfortunately I didn't have time to try
it out this week, maybe I'll have some free time to check these builds next
week, or if you're up for it and have some time for it feel free to check it
out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
