james94 commented on code in PR #1793:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1793#discussion_r1764491347
##########
cmake/BundledRocksDB.cmake:
##########
@@ -63,10 +64,17 @@ function(use_bundled_rocksdb SOURCE_DIR BINARY_DIR)
-DROCKSDB_INSTALL_ON_WINDOWS=ON
-DWITH_XPRESS=ON)
else()
+ if(MINIFI_ZSTD_SOURCE STREQUAL "CONAN" AND MINIFI_ZLIB_SOURCE STREQUAL
"CONAN")
+ list(APPEND ROCKSDB_CMAKE_ARGS
+ -DWITH_ZLIB=OFF
+ -DWITH_ZSTD=OFF)
+ else()
Review Comment:
It is possible to fix RocksDB with conan zlib and zstd. I will try to add
support for RocksDB conan as alternative to RocksDB cmake, so we can undo the
updates that I made to BundledRocksDB.cmake, so that BundledRocksDB.cmake just
stays standalone CMake specific and separate from conan. I will follow up on
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
