[ https://issues.apache.org/jira/browse/NIFI-13989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896719#comment-17896719 ]
Daniel Stieglitz commented on NIFI-13989: ----------------------------------------- I am fine with that. It just seems very hard to add parameters without having to juggle a bunch of different constructors. It would be simpler with an argument object. > Refactor JsonTreeRowRecordReader constructor to take a parameter object > ----------------------------------------------------------------------- > > Key: NIFI-13989 > URL: https://issues.apache.org/jira/browse/NIFI-13989 > Project: Apache NiFi > Issue Type: Improvement > Reporter: Daniel Stieglitz > Assignee: Daniel Stieglitz > Priority: Minor > > When attempting a fix for NIFI-13963 I found it very hard to add another > argument as there already 13 arguments for the current constructor. This is a > code smell Martin Fowler identifies as a long parameter list > [https://luzkan.github.io/smells/long-parameter-list.|https://luzkan.github.io/smells/long-parameter-list] > One of the solutions is to create a parameter object to encompass all the > arguments. -- This message was sent by Atlassian Jira (v8.20.10#820010)