[
https://issues.apache.org/jira/browse/NIFI-13989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897581#comment-17897581
]
ASF subversion and git services commented on NIFI-13989:
--------------------------------------------------------
Commit f15b7caaa483588869553cc7f84f98dfcbbd475a in nifi's branch
refs/heads/main from dan-s1
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=f15b7caaa4 ]
NIFI-13989 Reduced constructors in JsonTreeRowRecordReader to one (#9506)
Signed-off-by: David Handermann <[email protected]>
> Refactor JsonTreeRowRecordReader constructor to take a parameter object
> -----------------------------------------------------------------------
>
> Key: NIFI-13989
> URL: https://issues.apache.org/jira/browse/NIFI-13989
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Daniel Stieglitz
> Assignee: Daniel Stieglitz
> Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> When attempting a fix for NIFI-13963 I found it very hard to add another
> argument as there are already 13 arguments for the current constructor. This
> is a code smell Martin Fowler identifies as a long parameter list
> [https://luzkan.github.io/smells/long-parameter-list.|https://luzkan.github.io/smells/long-parameter-list]
> One of the solutions is to create a parameter object to encompass all the
> arguments.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
