[
https://issues.apache.org/jira/browse/NIFI-13989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896720#comment-17896720
]
David Handermann commented on NIFI-13989:
-----------------------------------------
Thanks for the reply [~dstiegli1].
It is worth noting that several of the overloaded constructors have usage
limited to test classes, so there may be some value in refactoring test
references to streamline the number of constructors. However, although the
number of constructor arguments has grown over time, this is not a
public-facing class. As such, I would not expect it to change very often.
> Refactor JsonTreeRowRecordReader constructor to take a parameter object
> -----------------------------------------------------------------------
>
> Key: NIFI-13989
> URL: https://issues.apache.org/jira/browse/NIFI-13989
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Daniel Stieglitz
> Assignee: Daniel Stieglitz
> Priority: Minor
>
> When attempting a fix for NIFI-13963 I found it very hard to add another
> argument as there are already 13 arguments for the current constructor. This
> is a code smell Martin Fowler identifies as a long parameter list
> [https://luzkan.github.io/smells/long-parameter-list.|https://luzkan.github.io/smells/long-parameter-list]
> One of the solutions is to create a parameter object to encompass all the
> arguments.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
