adamdebreceni commented on code in PR #1902:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1902#discussion_r1950962128
##########
extensions/rocksdb-repos/CMakeLists.txt:
##########
@@ -30,8 +30,9 @@ file(GLOB SOURCES "*.cpp" "controllers/*.cpp"
"database/*.cpp" "encryption/*.cp
add_minifi_library(minifi-rocksdb-repos SHARED ${SOURCES})
-target_link_libraries(minifi-rocksdb-repos ${LIBMINIFI} Threads::Threads)
-target_link_libraries(minifi-rocksdb-repos RocksDB::RocksDB)
+target_link_libraries(minifi-rocksdb-repos PUBLIC RocksDB::RocksDB)
+target_link_libraries(minifi-rocksdb-repos PUBLIC minifi-core
minifi-extension-utils Threads::Threads)
+target_link_libraries(minifi-rocksdb-repos PRIVATE $<LINK_ONLY:core-minifi>)
Review Comment:
renamed to minifi-api in
https://github.com/apache/nifi-minifi-cpp/pull/1902/commits/c1fddd9c0bd6226d2dd9e0c14b6c84060d30afae
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
