szaszm commented on code in PR #1902:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1902#discussion_r1952599553
##########
utils/CMakeLists.txt:
##########
@@ -0,0 +1,22 @@
+file(GLOB SOURCES
+ src/*.cpp
+ src/core/*.cpp
+ src/core/extension/*.cpp
+ src/io/*.cpp
+ src/http/*.cpp
+ src/utils/*.cpp
+ src/utils/crypto/*.cpp
+ src/utils/crypto/ciphers/*.cpp
+ src/utils/crypto/property_encryption/*.cpp
+ src/utils/net/*.cpp
+ src/utils/file/*.cpp)
+
+add_minifi_library(minifi-utils STATIC ${SOURCES})
+target_include_directories(minifi-utils PUBLIC include)
+target_link_libraries(minifi-utils PUBLIC minifi-api ZLIB::ZLIB
concurrentqueue RapidJSON spdlog Threads::Threads gsl-lite libsodium range-v3
expected-lite date::date date::tz asio magic_enum OpenSSL::Crypto OpenSSL::SSL
CURL::libcurl RapidJSON)
+if(NOT WIN32)
+ target_link_libraries(minifi-utils PUBLIC OSSP::libuuid++)
+endif()
+if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU" AND CMAKE_CXX_COMPILER_VERSION
VERSION_LESS 9)
+ target_link_libraries(minifi-utils PUBLIC stdc++fs)
+endif()
Review Comment:
```suggestion
endif()
```
##########
extension-utils/CMakeLists.txt:
##########
@@ -0,0 +1,35 @@
+file(GLOB SOURCES
+ src/*.cpp
+ src/core/*.cpp
+ src/controllers/keyvalue/*.cpp
+ src/controllers/*.cpp
+ src/io/*.cpp
+ src/serialization/*.cpp
+ src/utils/file/*.cpp
+ src/utils/net/*.cpp
+ src/utils/tls/*.cpp
+ src/utils/*.cpp)
+add_minifi_library(minifi-extension-utils STATIC ${SOURCES})
+target_include_directories(minifi-extension-utils PUBLIC include)
+target_link_libraries(minifi-extension-utils PUBLIC minifi-api)
+
+include(RangeV3)
+include(Asio)
+include(MagicEnum)
+list(APPEND CORE_LIBRARIES ZLIB::ZLIB concurrentqueue RapidJSON spdlog
Threads::Threads gsl-lite range-v3 expected-lite asio magic_enum
OpenSSL::Crypto OpenSSL::SSL CURL::libcurl RapidJSON)
+if(NOT WIN32)
+ list(APPEND CORE_LIBRARIES OSSP::libuuid++)
+endif()
+if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU" AND CMAKE_CXX_COMPILER_VERSION
VERSION_LESS 9)
+ list(APPEND CORE_LIBRARIES stdc++fs)
+endif()
+target_link_libraries(minifi-extension-utils PUBLIC ${CMAKE_DL_LIBS}
${CORE_LIBRARIES})
+if (APPLE)
+ target_link_libraries(minifi-extension-utils PUBLIC "-framework
CoreFoundation -framework SystemConfiguration")
+endif()
+if (UNIX AND (CMAKE_SYSTEM_PROCESSOR MATCHES "armv7"))
+ target_link_libraries(minifi-extension-utils PUBLIC "-latomic")
+endif()
+
+target_link_libraries(minifi-extension-utils PRIVATE minifi-api)
+target_link_libraries(minifi-extension-utils PUBLIC minifi-utils)
Review Comment:
```suggestion
target_link_libraries(minifi-extension-utils PUBLIC minifi-utils)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
