fgerlits commented on code in PR #1926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1926#discussion_r1981828179
##########
extensions/couchbase/controllerservices/CouchbaseClusterService.cpp:
##########
@@ -216,12 +216,10 @@ void CouchbaseClusterService::initialize() {
}
void CouchbaseClusterService::onEnable() {
- std::string connection_string;
- getProperty(ConnectionString, connection_string);
- std::string username;
- getProperty(UserName, username);
- std::string password;
- getProperty(UserPassword, password);
+ std::string connection_string = getProperty(ConnectionString.name) |
utils::expect("required property");
Review Comment:
This message is misleading, as this will only throw if `ConnectionString` is
not a supported property (ie., never).
Maybe we could have two types of `utils::expect` (with two different names,
of course), one that throws and one that terminates (for situations which
should be impossible)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
