fgerlits commented on code in PR #1926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1926#discussion_r1991450176
##########
extensions/mqtt/processors/PublishMQTT.cpp:
##########
@@ -138,11 +132,15 @@ bool PublishMQTT::sendMessage(const
std::vector<std::byte>& buffer, const std::s
}
void PublishMQTT::checkProperties() {
+ auto is_property_explicitly_set = [this](const std::string_view
property_name) -> bool {
+ const auto property_values = getAllPropertyValues(property_name) |
utils::expect("It should only be called on valid property");
Review Comment:
I was thinking of repurposing `utils::expect` to do a `gsl_Expect` and using
something else, eg. `utils::verify`, for the throwing case.
But `utils::orTerminate` is fine, too -- or maybe other people have better
ideas than either of these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
