martinzink commented on code in PR #1926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1926#discussion_r1991363765


##########
extensions/mqtt/processors/PublishMQTT.cpp:
##########
@@ -138,11 +132,15 @@ bool PublishMQTT::sendMessage(const 
std::vector<std::byte>& buffer, const std::s
 }
 
 void PublishMQTT::checkProperties() {
+  auto is_property_explicitly_set = [this](const std::string_view 
property_name) -> bool {
+    const auto property_values = getAllPropertyValues(property_name) | 
utils::expect("It should only be called on valid property");

Review Comment:
   Any idea for naming said function? utils::assert would be good but assert is 
already a macro name



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to