exceptionfactory commented on code in PR #10433:
URL: https://github.com/apache/nifi/pull/10433#discussion_r2440664771
##########
nifi-extension-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/kafka/processors/ConsumeKafka.java:
##########
@@ -142,8 +143,7 @@ public class ConsumeKafka extends AbstractProcessor
implements VerifiableProcess
.build();
static final PropertyDescriptor AUTO_OFFSET_RESET = new
PropertyDescriptor.Builder()
- .name("auto.offset.reset")
- .displayName("Auto Offset Reset")
+ .name("Auto Offset Reset")
Review Comment:
In this particular case, the original name should be retained to match the
Kafka property name.
##########
nifi-extension-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/kafka/processors/PublishKafka.java:
##########
@@ -131,8 +132,7 @@ public class PublishKafka extends AbstractProcessor
implements VerifiableProcess
.build();
static final PropertyDescriptor DELIVERY_GUARANTEE = new
PropertyDescriptor.Builder()
- .name("acks")
- .displayName("Delivery Guarantee")
+ .name("Delivery Guarantee")
.description("Specifies the requirement for guaranteeing that a
message is sent to Kafka. Corresponds to Kafka Client acks property.")
Review Comment:
As these match Kafka client properties, they should remain as-is.
##########
nifi-extension-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/processors/PublishJMS.java:
##########
@@ -133,8 +132,7 @@ public class PublishJMS extends
AbstractJMSProcessor<JMSPublisher> {
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
.build();
static final PropertyDescriptor ATTRIBUTES_AS_HEADERS_REGEX = new
PropertyDescriptor.Builder()
- .name("attributes-to-send-as-jms-headers-regex")
- .displayName("Attributes to Send as JMS Headers (Regex)")
+ .name("Attributes to Send as JMS Headers (Regex)")
Review Comment:
The description is sufficient to indicate regular expressions needed.
```suggestion
.name("Attributes to Send as JMS Headers")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
