dan-s1 commented on code in PR #10433:
URL: https://github.com/apache/nifi/pull/10433#discussion_r2440696969
##########
nifi-extension-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/kafka/processors/PublishKafka.java:
##########
@@ -131,8 +132,7 @@ public class PublishKafka extends AbstractProcessor
implements VerifiableProcess
.build();
static final PropertyDescriptor DELIVERY_GUARANTEE = new
PropertyDescriptor.Builder()
- .name("acks")
- .displayName("Delivery Guarantee")
+ .name("Delivery Guarantee")
.description("Specifies the requirement for guaranteeing that a
message is sent to Kafka. Corresponds to Kafka Client acks property.")
Review Comment:
Thanks for clarifying these. What about the others in `PublishKafka` such as
`compression.type,` `max.request.size`, `partitioner.class` and `partition`,
do they also need to be reverted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
