dan-s1 commented on PR #10433: URL: https://github.com/apache/nifi/pull/10433#issuecomment-3416521446
> > > Thanks @dan-s1. I noted one renaming suggestion, and I think all of the Kafka properties should remain unchanged. In this particular case, the property names match Kafka client names, so it is useful to maintain the matching names. > > > > > > I only made changes for the `ConsumeKafka` and `PublishKafka` processors as those are the ones I saw you mad comments on. Did you also mean for me to revert the changes made in `Kafka3ConnectionService` ? > > Yes, thanks, all Kafka-related changes should be reverted. Sorry one more clarification. What about the changes to `AmazonMSKConnectionService` which extends `Kafka3ConnectionService` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
