lordgamez commented on code in PR #2044:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2044#discussion_r2469983384
##########
extensions/sql/tests/features/sql.feature:
##########
@@ -29,13 +26,13 @@ Feature: Executing SQL operations from MiNiFi-C++
And the "success" relationship of the GenerateFlowFile processor is
connected to the UpdateAttribute
And the "success" relationship of the UpdateAttribute processor is
connected to the PutSQL
And an ODBCService is setup up for PutSQL with the name "ODBCService"
+ And PutSQL's success relationship is auto-terminated
And a PostgreSQL server is set up
When all instances start up
Then the query "SELECT * FROM test_table WHERE int_col = 42" returns 1
rows in less than 60 seconds on the PostgreSQL server
Review Comment:
I think this test fails in the CI due to the issues I also encountered when
running this test:
- The check searches for "rows" in the output while if a single line is
inserted it only returns the output "1 row" so "rows" is not found
- When uniqueness is not guaranteed in the table the same line is inserted
multiple times so the query might return multiple lines instead of the single
row that is checked
I added some changes to fix these issues in the
`extensions/sql/tests/features/sql.feature` and
`extensions/sql/tests/features/steps/postgress_server_container.py` files to
fix these issues in https://github.com/apache/nifi-minifi-cpp/pull/2052/ that
could be added to this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
