lordgamez commented on code in PR #2044:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2044#discussion_r2470001478
##########
.github/workflows/ci.yml:
##########
@@ -535,6 +535,64 @@ jobs:
with:
name: behavex_output
path: build/behavex_output
+ modular_docker_tests:
+ name: "Modular Docker integration tests (x86_64)"
+ needs: docker_build
+ runs-on: ubuntu-24.04
+ timeout-minutes: 180
+ steps:
+ - id: checkout
+ uses: actions/checkout@v4
+ - id: run_cmake
+ name: Run CMake
+ run: |
+ mkdir build
+ cd build
+ cmake ${DOCKER_CMAKE_FLAGS} ..
+ - name: Download artifact
+ uses: actions/download-artifact@v4
+ with:
+ name: minifi_docker
+ path: build
+ - name: Load Docker image
+ run: |
+ docker load --input ./build/minifi_docker.tar
+ - id: install_deps
+ name: Install dependencies for Docker Verify
+ run: |
+ sudo apt update
+ sudo apt install -y python3-virtualenv
+ - id: free_disk_space
+ run: |
+ # We can gain additional disk space on the Ubuntu runners thanks to
these suggestions:
+ #
https://github.com/actions/runner-images/issues/2840#issuecomment-790492173
+ #
https://github.com/actions/runner-images/issues/2606#issuecomment-772683150
+ sudo rm -rf /usr/share/dotnet
+ sudo rm -rf /usr/local/lib/android
+ sudo rm -rf /opt/ghc
+ sudo rm -rf "/usr/local/share/boost"
+ sudo rm -rf "$AGENT_TOOLSDIRECTORY"
+ - id: test
+ name: Docker Verify
+ working-directory: ./build
+ run: make docker-verify-modular
Review Comment:
I would also add a markdown file with the steps for setting up the
virtualenv and use behavex to run a single extension's test scenarios, maybe an
additional helper script to make it easier.
Also how much effort would it take to remove all `typing` package imports
and use the built in types for the type hints if we want to use the modernized
type hints of python 3.10 everywhere, like list[], tuple[], | etc. instead of
typing.List[], typing.Tuple[], typing.Optiona[]? Could that be changed in this
PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
