szaszm commented on code in PR #2077:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2077#discussion_r2606478287
##########
behave_framework/src/minifi_test_framework/steps/flow_building_steps.py:
##########
@@ -61,6 +60,9 @@ def step_impl(context: MinifiTestContext, processor_type:
str, property_name: st
def step_impl(context: MinifiTestContext, processor_type: str, property_name:
str, property_value: str, minifi_container_name: str):
processor = Processor(processor_type, processor_type)
processor.add_property(property_name, property_value)
+ if minifi_container_name == "nifi":
+ context.containers["nifi"].flow_definition.add_processor(processor)
+ return
Review Comment:
This way of deciding what to do raises a red flag for me, but I'll leave it
up to @martinzink to say if this design fits in the framework or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
