lordgamez commented on code in PR #2077:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2077#discussion_r2717681853
##########
behave_framework/src/minifi_test_framework/steps/flow_building_steps.py:
##########
@@ -61,6 +60,9 @@ def step_impl(context: MinifiTestContext, processor_type:
str, property_name: st
def step_impl(context: MinifiTestContext, processor_type: str, property_name:
str, property_value: str, minifi_container_name: str):
processor = Processor(processor_type, processor_type)
processor.add_property(property_name, property_value)
+ if minifi_container_name == "nifi":
+ context.containers["nifi"].flow_definition.add_processor(processor)
+ return
Review Comment:
It could work if we rename the `get_or_create_minifi_container` to
`get_or_create_flow_container` for example. In that case we expect that "nifi"
container to already exist in the container map before adding a new processor,
so it returns a `NifiContainer` instead of a `MiNifiContainer` in that case (we
could create a common base class at least for a common return value). If the
container does not exist yet we would always return a MiNifiContainer. It still
feels a bit strange to just always expect NiFi container to be created
beforehand and have the default return value to be a `MiNifiContainer` object,
but I can live with it. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
