lordgamez commented on code in PR #2077:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2077#discussion_r2671637468
##########
behave_framework/src/minifi_test_framework/steps/flow_building_steps.py:
##########
@@ -61,6 +60,9 @@ def step_impl(context: MinifiTestContext, processor_type:
str, property_name: st
def step_impl(context: MinifiTestContext, processor_type: str, property_name:
str, property_value: str, minifi_container_name: str):
processor = Processor(processor_type, processor_type)
processor.add_property(property_name, property_value)
+ if minifi_container_name == "nifi":
+ context.containers["nifi"].flow_definition.add_processor(processor)
+ return
Review Comment:
In the first design of the new framework the flow building steps assumed
that the steps are only meant for minifi and that there is only 1 minifi
container in the test scenario. Later this was changed to be able to have
multiple minifi containers in a test scenario and for that containers are
identified and stored by their names. As we only have a single NiFi container
in all of our tests involving NiFi it seemed to be the easiest approach to
check the container name in case we want to add a flow step to the container. I
also see that this may be a bit iffy in case we want to use multiple NiFi
containers in a scenario in the future, but I could not find a better yet clean
solution for this, so it can be up for discussion and I'm open for new ideas.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
