Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/43#discussion_r100845905
  
    --- Diff: libminifi/CMakeLists.txt ---
    @@ -48,6 +49,19 @@ file(GLOB SPD_SOURCES "../include/spdlog/*")
     add_library(spdlog STATIC ${SPD_SOURCES})
     add_library(minifi STATIC ${SOURCES})
     
    +# Include Boost System
    +find_package(Boost COMPONENTS system REQUIRED)
    --- End diff --
    
    There seemed to be a little hesitation about using boost. My guess is that 
-Os added to flags won't actually cause the expected increase; however, it does 
potentially cause some bloat. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to