Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/43#discussion_r100844559
  
    --- Diff: libminifi/include/ProcessSessionFactory.h ---
    @@ -0,0 +1,52 @@
    +/**
    + * @file ProcessSessionFactory.h
    + * ProcessSessionFactory class declaration
    + *
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +#ifndef __PROCESS_SESSION_FACTORY_H__
    +#define __PROCESS_SESSION_FACTORY_H__
    +
    +#include <memory>
    +
    +#include "ProcessContext.h"
    +#include "ProcessSession.h"
    +
    +//! ProcessSessionFactory Class
    +class ProcessSessionFactory
    +{
    +public:
    +   //! Constructor
    +   /*!
    +    * Create a new process session factory
    +    */
    +   ProcessSessionFactory(ProcessContext *processContext) : 
_processContext(processContext) {}
    +
    +   //! Create the session
    +   std::unique_ptr<ProcessSession> createSession();
    --- End diff --
    
    It is my goal to make pointer usage clear. Thanks for making this 
exceptionally clear with unique_ptr here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to