exceptionfactory commented on code in PR #10653:
URL: https://github.com/apache/nifi/pull/10653#discussion_r2632696868
##########
nifi-extension-bundles/nifi-asn1-bundle/nifi-asn1-services/src/main/java/org/apache/nifi/jasn1/JASN1Reader.java:
##########
@@ -70,13 +70,14 @@
import java.util.Set;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.stream.Collectors;
+import java.util.stream.Stream;
@Tags({"asn", "ans1", "jasn.1", "jasn1", "record", "reader", "parser"})
@CapabilityDescription("Reads ASN.1 content and creates NiFi records. " +
"NOTE: ASN.1 schema preparation requires the JDK at runtime for model
compilation.")
public class JASN1Reader extends AbstractConfigurableComponent implements
RecordReaderFactory {
- private static final PropertyDescriptor ROOT_MODEL_NAME = new
PropertyDescriptor.Builder()
+ static final PropertyDescriptor ROOT_MODEL_NAME = new
PropertyDescriptor.Builder()
Review Comment:
The indentation of this line and others is off by one space.
##########
nifi-extension-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/s3/AbstractS3Processor.java:
##########
@@ -45,15 +45,15 @@
public abstract class AbstractS3Processor extends
AbstractAwsSyncProcessor<S3Client, S3ClientBuilderWrapper> {
// Obsolete property names
+ public static final String OBSOLETE_SIGNER_OVERRIDE = "Signer Override";
+ public static final String OBSOLETE_CUSTOM_SIGNER_CLASS_NAME_1 =
"custom-signer-class-name";
+ public static final String OBSOLETE_CUSTOM_SIGNER_CLASS_NAME_2 = "Custom
Signer Class Name";
+ public static final String OBSOLETE_CUSTOM_SIGNER_MODULE_LOCATION_1 =
"custom-signer-module-location";
+ public static final String OBSOLETE_CUSTOM_SIGNER_MODULE_LOCATION_2 =
"Custom Signer Module Location";
Review Comment:
Introducing `public static` variables makes it harder to trace down
references to this class, I recommend avoiding this approach for migration
tests.
##########
nifi-extension-bundles/nifi-asn1-bundle/nifi-asn1-services/src/test/java/org/apache/nifi/jasn1/JASN1ReaderTest.java:
##########
@@ -73,9 +76,10 @@ public void tearDown() throws Exception {
mockCloseable.close();
}
- assertTrue(testSubject.asnOutDir.toFile().exists());
- testSubject.deleteAsnOutDir();
- assertFalse(testSubject.asnOutDir.toFile().exists());
+ if (testSubject.asnOutDir != null &&
testSubject.asnOutDir.toFile().exists()) {
+ testSubject.deleteAsnOutDir();
+ assertFalse(testSubject.asnOutDir.toFile().exists());
+ }
Review Comment:
The indentation of this block appears to be off.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
