exceptionfactory commented on code in PR #10653:
URL: https://github.com/apache/nifi/pull/10653#discussion_r2636730923
##########
nifi-extension-bundles/nifi-asn1-bundle/nifi-asn1-services/src/main/java/org/apache/nifi/jasn1/JASN1Reader.java:
##########
@@ -70,22 +70,23 @@
import java.util.Set;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.stream.Collectors;
+import java.util.stream.Stream;
@Tags({"asn", "ans1", "jasn.1", "jasn1", "record", "reader", "parser"})
@CapabilityDescription("Reads ASN.1 content and creates NiFi records. " +
"NOTE: ASN.1 schema preparation requires the JDK at runtime for model
compilation.")
public class JASN1Reader extends AbstractConfigurableComponent implements
RecordReaderFactory {
- private static final PropertyDescriptor ROOT_MODEL_NAME = new
PropertyDescriptor.Builder()
- .name("Root Model Name")
- .description("The model name in the form of 'MODULE-NAME.ModelType'. "
+
- "Mutually exclusive with and should be preferred to 'Root Model
Class Name'. (See additional details for more information.)")
-
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
- .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
- .required(false)
- .build();
+ static final PropertyDescriptor ROOT_MODEL_NAME = new
PropertyDescriptor.Builder()
+ .name("Root Model Name")
+ .description("The model name in the form of
'MODULE-NAME.ModelType'. " +
+ "Mutually exclusive with and should be preferred to 'Root
Model Class Name'. (See additional details for more information.)")
+
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
+ .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+ .required(false)
+ .build();
- private static final PropertyDescriptor ROOT_CLASS_NAME = new
PropertyDescriptor.Builder()
+ static final PropertyDescriptor ROOT_CLASS_NAME = new
PropertyDescriptor.Builder()
Review Comment:
All of the changed lines for property descriptors appear to be off by one
space in this file
##########
nifi-extension-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/AbstractAwsProcessor.java:
##########
@@ -79,16 +79,16 @@
* @see <a
href="https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/auth/credentials/AwsCredentialsProvider.html";>AwsCredentialsProvider</a>
*/
public abstract class AbstractAwsProcessor<C extends AwsClient, B extends
AwsClientBuilder<B, C>> extends AbstractSessionFactoryProcessor implements
VerifiableProcessor {
- private static final String CREDENTIALS_SERVICE_CLASSNAME =
"org.apache.nifi.processors.aws.credentials.provider.service.AWSCredentialsProviderControllerService";
-
// Obsolete property names
- private static final String OBSOLETE_ACCESS_KEY = "Access Key";
- private static final String OBSOLETE_SECRET_KEY = "Secret Key";
- private static final String OBSOLETE_CREDENTIALS_FILE = "Credentials File";
- private static final String OBSOLETE_PROXY_HOST = "Proxy Host";
- private static final String OBSOLETE_PROXY_PORT = "Proxy Host Port";
- private static final String OBSOLETE_PROXY_USERNAME = "proxy-user-name";
- private static final String OBSOLETE_PROXY_PASSWORD =
"proxy-user-password";
+ public static final String OBSOLETE_ACCESS_KEY = "Access Key";
+ public static final String OBSOLETE_SECRET_KEY = "Secret Key";
+ public static final String OBSOLETE_CREDENTIALS_FILE = "Credentials File";
+ public static final String OBSOLETE_PROXY_HOST = "Proxy Host";
+ public static final String OBSOLETE_PROXY_PORT = "Proxy Host Port";
+ public static final String OBSOLETE_PROXY_USERNAME = "proxy-user-name";
+ public static final String OBSOLETE_PROXY_PASSWORD = "proxy-user-password";
Review Comment:
Can these changes to `public` also be reverted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
