dan-s1 commented on code in PR #10653:
URL: https://github.com/apache/nifi/pull/10653#discussion_r2635196848


##########
nifi-extension-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/s3/AbstractS3Processor.java:
##########
@@ -45,15 +45,15 @@
 public abstract class AbstractS3Processor extends 
AbstractAwsSyncProcessor<S3Client, S3ClientBuilderWrapper> {
 
     // Obsolete property names
+    public static final String OBSOLETE_SIGNER_OVERRIDE = "Signer Override";
+    public static final String OBSOLETE_CUSTOM_SIGNER_CLASS_NAME_1 = 
"custom-signer-class-name";
+    public static final String OBSOLETE_CUSTOM_SIGNER_CLASS_NAME_2 = "Custom 
Signer Class Name";
+    public static final String OBSOLETE_CUSTOM_SIGNER_MODULE_LOCATION_1 = 
"custom-signer-module-location";
+    public static final String OBSOLETE_CUSTOM_SIGNER_MODULE_LOCATION_2 = 
"Custom Signer Module Location";

Review Comment:
   That is funny I thought it would be easier to trace down when used in 
variables  than hard coded values.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to