sfc-gh-lkucharski commented on code in PR #10881:
URL: https://github.com/apache/nifi/pull/10881#discussion_r2797744621
##########
nifi-extension-bundles/nifi-aws-bundle/nifi-aws-kinesis/src/main/java/org/apache/nifi/processors/aws/kinesis/RecordBuffer.java:
##########
@@ -37,7 +37,7 @@ interface ForKinesisClientLibrary {
ShardBufferId createBuffer(String shardId);
- void addRecords(ShardBufferId bufferId, List<KinesisClientRecord>
records, RecordProcessorCheckpointer checkpointer);
+ void addRecords(ShardBufferId bufferId, List<KinesisClientRecord>
records, RecordProcessorCheckpointer checkpointer, Long millisBehindLatest);
Review Comment:
Since we talked about it before the implementation and agreed to just add
another parameter I'm going to leave the refactor for the next soul
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
