sfc-gh-lkucharski commented on code in PR #10881:
URL: https://github.com/apache/nifi/pull/10881#discussion_r2798383333
##########
nifi-extension-bundles/nifi-aws-bundle/nifi-aws-kinesis/src/main/java/org/apache/nifi/processors/aws/kinesis/ConsumeKinesis.java:
##########
@@ -761,7 +770,8 @@ public void processRecords(final ProcessRecordsInput
processRecordsInput) {
if (bufferId == null) {
throw new IllegalStateException("Buffer ID not found: Record
Processor not initialized");
}
- recordBuffer.addRecords(bufferId, processRecordsInput.records(),
processRecordsInput.checkpointer());
+ recordBuffer.addRecords(bufferId, processRecordsInput.records(),
+ processRecordsInput.checkpointer(),
processRecordsInput.millisBehindLatest());
Review Comment:
I think millisBehindLatetest is what this metric should be about. The fact
that records spent some time in caches will be factored into e2e metrics.
I'll add the information what this metric means in the documentation once
it's ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
