sfc-gh-lkucharski commented on code in PR #10881:
URL: https://github.com/apache/nifi/pull/10881#discussion_r2813854694
##########
nifi-extension-bundles/nifi-aws-bundle/nifi-aws-kinesis/src/main/java/org/apache/nifi/processors/aws/kinesis/ConsumeKinesis.java:
##########
@@ -145,6 +146,8 @@ Uses DynamoDB for check pointing and coordination, and
(optional) CloudWatch for
description = "A SubSequence Number of the last Kinesis Record
in the FlowFile. Generated by KPL when aggregating records into a single
Kinesis Record"),
@WritesAttribute(attribute = APPROXIMATE_ARRIVAL_TIMESTAMP,
description = "Approximate arrival timestamp of the last
Kinesis Record in the FlowFile"),
+ @WritesAttribute(attribute = MILLIS_BEHIND_LATEST,
+ description = "Milliseconds behind the latest record in the
shard at the time records were consumed"),
Review Comment:
I decided to add it as an FF attribute to be able to report this metric even
if the `makeMillisBehindLatestGaugeName` format will be deemed too OpenFlow
specific by the maintainers.
Our current internal OF format for metric with attributes is
`some.metric.name[arg.1="123",arg.2="456"]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
