pvillard31 opened a new pull request, #10972:
URL: https://github.com/apache/nifi/pull/10972

   # Summary
   
   NIFI-15673 - Add support for Author+Committer with git-based Flow Registry 
Clients
   
   Right now, in NiFi, when using a git-based Flow Registry Client, all commits 
are made with the identity that is configured for the authentication of the 
registry client. It means that if many users are using the same NiFi UI, all 
commits made by different users will be reported as being made with the same 
user (likely the service account used in the registry client configuration).
   
   This is not ideal when working with multiple users and trying to distinguish 
who made the actual commits.
   
   With the git-based implementations, it is possible to make a commit and 
specify both an author and a committer.
   
   This change is to use the identity of the NiFi User connected in the UI as 
the author and use the identity configured in the registry client as the 
committer.
   
   Important notes:
   - the proposed implementation in GitHub is using reflection as a temporary 
workaround until a submitted improvement is accepted/merged/released (see 
https://github.com/hub4j/github-api/pull/2200)
   - if the NiFi User does not resolve to an email address, the identity won't 
be resolved on the git provider side and it will just show the author as an 
unkown user with just the NiFi identity
   - I didn't see an option to do that with Bitbucket Data Center
   
   This has been tested with GitHub, GitLab, Azure DevOps and Bitbucket cloud. 
See some screenshots below.
   
   A potential follow-up improvement would be to show this information in the 
UI in the views where we list flow versions.
   
   # Screenshots
   
   ### When my NiFi identity does NOT resolve to a user in the git provider:
   
   #### GitHub
   
   <img width="1311" height="116" alt="Screenshot 2026-03-05 at 12 02 32" 
src="https://github.com/user-attachments/assets/4e722380-7f13-4142-bbf9-099774c6a10c";
 />
   
   #### GitLab
   
   <img width="1362" height="116" alt="Screenshot 2026-03-05 at 12 02 54" 
src="https://github.com/user-attachments/assets/6d1d6711-463a-4f43-ac5b-7ac1fdebda89";
 />
   
   #### Bitbucket (only the author is shown in the UI - see 
https://jira.atlassian.com/browse/BCLOUD-13836)
   
   <img width="1726" height="121" alt="Screenshot 2026-03-05 at 12 03 31" 
src="https://github.com/user-attachments/assets/bb727dbf-4d2a-4dfa-8f37-15b0c6319197";
 />
   
   ### When my NiFi identity does resolve to a user in the git provider:
   
   <img width="294" height="121" alt="Screenshot 2026-03-05 at 12 12 38" 
src="https://github.com/user-attachments/assets/17502973-9635-4108-b299-300acb3f52d4";
 />
   
   #### GitHub
   
   <img width="1330" height="234" alt="Screenshot 2026-03-05 at 12 12 19" 
src="https://github.com/user-attachments/assets/fae5ed25-9c54-4f09-90a3-43e2e5c769be";
 />
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-00000`
   - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-00000`
   - [ ] Pull request contains [commits 
signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits)
 with a registered key indicating `Verified` status
   
   ### Pull Request Formatting
   
   - [ ] Pull Request based on current revision of the `main` branch
   - [ ] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [ ] Build completed using `./mvnw clean install -P contrib-check`
     - [ ] JDK 21
     - [ ] JDK 25
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to