pvillard31 commented on PR #10972: URL: https://github.com/apache/nifi/pull/10972#issuecomment-4066808459
> There is certainly value is tracing the commit author, but as described and implemented, it requires the NiFi user identity to be an email address, which may not be the case in many situations. One possibility to attempting to determine if it is an email address. That is not true. Any string will work. Git providers will only try to do account matching if the provided string is an email. If not, it'll just use the string as-is. One of the screenshots is exactly that scenario. > Considering this from another perspective, what about adding some trailer to the commit message footer? One possibility is the common Co-authored-by. This still requires a name and email address for exact matching, but as a footer, it is more open to interpretation. What I don't really like about this approach is that this is just some text added to the commit message. Firstly, users could add their own Co-authored-by in the comment of the flow version and secondly, the next step of this effort would be to display author/committer information in the UI when listing flow versions and relying on parsing comments would not be great IMO. > The email could also be derived according to the Git service, such as [email protected] and [email protected]. The approach only requires a NiFi username matching the Git service username. If it doesn't match, it is less of an issue. I didn't know about this but not sure to really see the benefit to be honest. In a world where SSO is used in most places, I feel like just taking the identity would be fine. > Another benefit of an approach based on the message footer is that it avoids the current reflection-based workaround. Yeah, I'm not a big fan of that but that would be temporary. I'm trying to get the PR merged and have another rc release for the github client. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
