exceptionfactory commented on PR #10972: URL: https://github.com/apache/nifi/pull/10972#issuecomment-4194669289
Thanks for the reply @pvillard31. For clarification on the NiFi user identity being an email address, I meant that it was a requirement in order to match against an actual Git user. I understand that any string is technically accepted in the author field. It is true that user's could add their own `Co-authored-by` lines to the footer, however, GitHub and other services specifically parse the "trailer" of a commit message to determine co-authorship. Taking a step back for a moment, I initially approached this change from the perspective of viewing commit authorship in GitHub or other Git service, as opposed to within NiFi. If the primary purpose is associating authorship in NiFi, that does change the analysis to some degree. My primary concern related to authorship linkage in the Git service, and the mismatch if the user identity is not an email address. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
