lordgamez commented on code in PR #2163:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2163#discussion_r3181574658
##########
libminifi/src/FlowController.cpp:
##########
@@ -130,6 +131,10 @@ std::expected<void, std::string>
FlowController::applyConfiguration(const std::s
std::lock_guard<std::recursive_mutex> flow_lock(mutex_);
stop();
+ // Clear the controller services now that all timer callback threads have
been stopped
+ clearControllerServices();
+ controller_service_provider_impl_ =
flow_configuration_->getControllerServiceProvider();
+
Review Comment:
Previously this was done as part of the FlowController::updateFromPayload
call on line 113, now the contents of that call have been separated and
clearing the controller services is done here instead under the mutex.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
