szaszm commented on code in PR #2163:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2163#discussion_r3196429998
##########
libminifi/src/FlowController.cpp:
##########
@@ -130,6 +131,10 @@ std::expected<void, std::string>
FlowController::applyConfiguration(const std::s
std::lock_guard<std::recursive_mutex> flow_lock(mutex_);
stop();
+ // Clear the controller services now that all timer callback threads have
been stopped
+ clearControllerServices();
+ controller_service_provider_impl_ =
flow_configuration_->getControllerServiceProvider();
+
Review Comment:
I was looking for the removed counterpart, but I checked and there is 1
other usage of FlowController::updateFromPayload, during the initial config
load, that's probably why you didn't remove it. I think it would be better to
remove the function and inline its contents to that 1 remaining usage site,
because the function name is misleading. (update vs initial load)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
