lordgamez commented on code in PR #2163:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2163#discussion_r3181580222
##########
libminifi/src/FlowController.cpp:
##########
@@ -110,7 +110,8 @@ FlowController::~FlowController() {
nonstd::expected<void, std::string> FlowController::applyConfiguration(const
std::string &source, const std::string &configurePayload, const
std::optional<std::string>& flow_id) {
std::unique_ptr<core::ProcessGroup> newRoot;
try {
- newRoot = updateFromPayload(source, configurePayload, flow_id);
+ // Parse the new flow here and and clear controller services later to
avoid race condition with the onScheduleTimer_ callback thread
Review Comment:
Fixed in
https://github.com/apache/nifi-minifi-cpp/pull/2163/commits/14287c7039353bde5dab6f7a2e142c8a281f00fa
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
