ing-mattioni commented on PR #11191: URL: https://github.com/apache/nifi/pull/11191#issuecomment-4439393400
> It looks good to me too. Just one minor question: why do `acknowledge()` and `negativeAcknowledge()` methods expose the boolean flag parameters when only `true` is ever passed? Good point @turcsanyip. I exposed the boolean parameters to mirror the underlying RabbitMQ `basicAck` / `basicNack` API and to make the cumulative acknowledgement behavior explicit at the call site. That said, in this processor we only need cumulative batch acknowledgement semantics, so exposing those flags is probably unnecessary. I can simplify the AMQPConsumer methods by removing the boolean parameters and keeping `multiple=true` and `requeue=true` inside the implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
