ing-mattioni commented on PR #11191: URL: https://github.com/apache/nifi/pull/11191#issuecomment-4439560923
@exceptionfactory, I rebased the branch against the latest `main`. I also simplified the acknowledgement methods following @turcsanyip's suggestion, keeping the cumulative `basicAck(..., true)` and requeueing `basicNack(..., true, true)` behavior encapsulated in `AMQPConsumer`. I am still looking into the best option for adding targeted test coverage for the commit callback behavior. The intended coverage would be: - successful `ProcessSession` commit calls `basicAck(lastDeliveryTag, true)` - failed `ProcessSession` commit calls `basicNack(lastDeliveryTag, true, true)` - auto-acknowledge mode does not issue manual ack/nack calls -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
