ing-mattioni commented on PR #11191:
URL: https://github.com/apache/nifi/pull/11191#issuecomment-4476650911
@exceptionfactory @turcsanyip I've added targeted unit test coverage for the
manual acknowledgement behavior introduced in this PR.
The new tests cover:
- Manual ack success path with Auto-Acknowledge Messages = false and Batch
Size > 1, verifying a single cumulative basicAck(lastDeliveryTag, true).
- Manual nack failure path by simulating ProcessSession commit failure,
verifying a single cumulative basicNack(lastDeliveryTag, true, true) and
confirming the original commit failure is preserved.
- Auto-ack mode, verifying that no manual basicAck or basicNack calls are
issued.
I also extended the test TestChannel helper to record ack/nack call counts
and arguments so the tests can assert the RabbitMQ cumulative acknowledgement
flags directly.
Verification completed:
- .\mvnw.cmd -pl :nifi-amqp-processors -am test
- .\mvnw.cmd -pl :nifi-amqp-processors -am -Pcontrib-check install
-DskipTests
The branch has also been checked against Apache upstream/main and is already
up to date.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
