ing-mattioni opened a new pull request, #11243: URL: https://github.com/apache/nifi/pull/11243
# Summary [NIFI-15935](https://issues.apache.org/jira/browse/NIFI-15935) This pull request updates `AbstractAMQPProcessor` to clean up AMQP resources more consistently after unexpected processor failures. When `processResource()` throws an unexpected exception, the processor currently logs the failure and yields the context. This change also rolls back the `ProcessSession` and closes the AMQP resource, ensuring that the client is dropped and recreated instead of potentially remaining in an inconsistent state. This change also ensures that the AMQP executor service is shut down when resource creation fails after the executor has been created. ## Changes - Rolls back the `ProcessSession` after unexpected processor failures - Closes the AMQP resource after unexpected processor failures - Shuts down the AMQP executor service when resource creation fails - Updates AMQP client executor thread naming to use a generic client name # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI-15935) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000` - [x] Pull request contains commits signed with a registered key indicating `Verified` status ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `./mvnw clean install -P contrib-check` - [ ] JDK 21 - [ ] JDK 25 Module-level verification performed: `.\mvnw.cmd -pl :nifi-amqp-processors -am test` Additional verification performed: `.\mvnw.cmd -pl :nifi-amqp-processors -am -P contrib-check install -DskipTests` ### Licensing - [x] New dependencies are compatible with the Apache License 2.0 - [x] New dependencies are documented in applicable `LICENSE` and `NOTICE` files No new dependencies were added. ### Documentation - [x] Documentation formatting appears as expected in rendered files No user-facing documentation files were changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
