ing-mattioni commented on code in PR #11243:
URL: https://github.com/apache/nifi/pull/11243#discussion_r3267004095
##########
nifi-extension-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AbstractAMQPProcessor.java:
##########
@@ -244,8 +244,10 @@ public final void onTrigger(final ProcessContext context,
final ProcessSession s
context.yield();
closeResource(resource);
} catch (Exception e) {
- getLogger().error("Processor failure", e);
+ getLogger().error("Processor failure, dropping the client", e);
+ session.rollback();
context.yield();
+ closeResource(resource);
}
Review Comment:
@turcsanyip so, if I understood correctly, you want to merge this PR to
close both this issue and NIFI-15892, while not merging the PR opened for
NIFI-15982 because the basic.nack is not really needed. Is it correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
