ing-mattioni commented on PR #11243: URL: https://github.com/apache/nifi/pull/11243#issuecomment-4476046910
> Thanks for proposing improvements @ing-mattioni. > > The try-catch around `session.rollback()` is not correct and should be removed. > > Closing the ExecutorService also appears to be incorrect. > > The goal of improving resource handling is good, but this needs to be reconsidered for the broader implications on exception handling. Updated based on the review. The rollback call is no longer wrapped in a try/catch, and the resource creation failure path no longer closes the ExecutorService directly. The generic exception path still rolls back the session and drops the AMQP client resource. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
