martinzink opened a new pull request, #2205: URL: https://github.com/apache/nifi-minifi-cpp/pull/2205
* removed MINIFI_NULL * remove struct/enum typedefs, and added struct/enum where necessary * CamelCase to snake_case (in minifi-api.h) * onTrigger -> trigger, onSChedule -> schedule, onUnSchedule -> unschedule * removed calculateMetrics from callbacks (replaced with minifi_process_context_report_metrics) * removed getTriggerWhenEmpty from callbacks (replaced with minifi_process_context_set_trigger_when_empty) * removed MinifiLoggerSetMaxLogSize (no replacement, we should reintroduce it if needed) * removed MinifiLoggerLevel (no replacement, we should reintroduce if needed) * removed c from API filenames (minifi-c-api.h -> minifi-api.h, minifi-c-api.def -> minifi-api.def etc.) * renamed minifi_property_definition::type -> minifi_property_definition::allowed_type * renamed class_properties_count -> properties_count, class_properties_ptr -> properties_ptr, class_relationships_ptr -> relationships_ptr etc * we also debated removing stdbool.h since we target C23 (but I've found that caused some problems in the rust wrapper so better to leave it for now) There is also a second commit which fixes a bug [remove minifiSystemControllerServiceType](https://github.com/apache/nifi-minifi-cpp/commit/d0b9ceea7b01e87e57527635dde2f9b88f0c1045) the resulting change can be seen in the .github/references/ubuntu_22_04_clang_arm_manifest.json --- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
