martinzink commented on code in PR #2205:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2205#discussion_r3473269084
##########
extension-framework/cpp-extension-lib/src/core/logging/Logger.cpp:
##########
@@ -33,36 +33,22 @@ MinifiLogLevel toCLogLevel(minifi::core::logging::LOG_LEVEL
lvl) {
}
gsl_FailFast();
}
-
-minifi::core::logging::LOG_LEVEL toLogLevel(MinifiLogLevel level) {
- switch (level) {
- case MINIFI_LOG_LEVEL_TRACE: return minifi::core::logging::trace;
- case MINIFI_LOG_LEVEL_DEBUG: return minifi::core::logging::debug;
- case MINIFI_LOG_LEVEL_INFO: return minifi::core::logging::info;
- case MINIFI_LOG_LEVEL_WARNING: return minifi::core::logging::warn;
- case MINIFI_LOG_LEVEL_ERROR: return minifi::core::logging::err;
- case MINIFI_LOG_LEVEL_CRITICAL: return minifi::core::logging::critical;
- case MINIFI_LOG_LEVEL_OFF: return minifi::core::logging::off;
- }
- gsl_FailFast();
-}
-
} // namespace
-void CffiLogger::set_max_log_size(const int size) {
- MinifiLoggerSetMaxLogSize(impl_, size);
+void CffiLogger::set_max_log_size(const int) {
+ throw std::runtime_error("Unimplemented C Api");
}
void CffiLogger::log_string(const minifi::core::logging::LOG_LEVEL level,
const std::string str) {
- MinifiLoggerLogString(impl_, toCLogLevel(level), MinifiStringView{.data =
str.data(), .length = str.length()});
+ minifi_logger_log_string(impl_, toCLogLevel(level), minifi_string_view{.data
= str.data(), .length = str.length()});
}
bool CffiLogger::should_log(const minifi::core::logging::LOG_LEVEL level) {
- return MinifiLoggerShouldLog(impl_, toCLogLevel(level));
+ return minifi_logger_should_log(impl_, toCLogLevel(level));
}
[[nodiscard]] minifi::core::logging::LOG_LEVEL CffiLogger::level() const {
- return toLogLevel(MinifiLoggerLevel(impl_));
+ throw std::runtime_error("Unimplemented C API");
}
Review Comment:
i think we should throw maybe even abort because this shouldnt be called in
theory
##########
extension-framework/cpp-extension-lib/src/core/logging/Logger.cpp:
##########
@@ -33,36 +33,22 @@ MinifiLogLevel toCLogLevel(minifi::core::logging::LOG_LEVEL
lvl) {
}
gsl_FailFast();
}
-
-minifi::core::logging::LOG_LEVEL toLogLevel(MinifiLogLevel level) {
- switch (level) {
- case MINIFI_LOG_LEVEL_TRACE: return minifi::core::logging::trace;
- case MINIFI_LOG_LEVEL_DEBUG: return minifi::core::logging::debug;
- case MINIFI_LOG_LEVEL_INFO: return minifi::core::logging::info;
- case MINIFI_LOG_LEVEL_WARNING: return minifi::core::logging::warn;
- case MINIFI_LOG_LEVEL_ERROR: return minifi::core::logging::err;
- case MINIFI_LOG_LEVEL_CRITICAL: return minifi::core::logging::critical;
- case MINIFI_LOG_LEVEL_OFF: return minifi::core::logging::off;
- }
- gsl_FailFast();
-}
-
} // namespace
-void CffiLogger::set_max_log_size(const int size) {
- MinifiLoggerSetMaxLogSize(impl_, size);
+void CffiLogger::set_max_log_size(const int) {
+ throw std::runtime_error("Unimplemented C Api");
}
Review Comment:
i think we should throw maybe even abort because this shouldnt be called in
theory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
