martinzink commented on code in PR #2205:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2205#discussion_r3473266586
##########
extension-framework/cpp-extension-lib/src/core/ProcessContext.cpp:
##########
@@ -62,23 +58,20 @@ std::expected<MinifiControllerService*, std::error_code>
CffiProcessContext::get
std::map<std::string, std::string>
CffiProcessContext::getDynamicProperties(const FlowFile* flow_file) const {
std::map<std::string, std::string> result;
- MinifiProcessContextGetDynamicProperties(
+ minifi_process_context_get_dynamic_properties(
impl_,
- flow_file ? flow_file->get() : MINIFI_NULL,
- [](void* user_ctx, const MinifiStringView key, const MinifiStringView
value) {
+ flow_file ? flow_file->get() : nullptr,
+ [](void* user_ctx, const minifi_string_view key, const
minifi_string_view value) {
static_cast<std::map<std::string,
std::string>*>(user_ctx)->emplace(utils::toString(key), utils::toString(value));
},
&result);
return result;
}
std::expected<std::optional<utils::net::SslData>, std::error_code>
CffiProcessContext::getSslData(const minifi::core::PropertyReference& prop)
const {
- const auto controller_name = getProperty(prop, nullptr);
- if (!controller_name) { return std::nullopt; }
-
auto ssl_data = utils::net::SslData{};
- if (const auto status = MinifiProcessContextGetSslDataFromProperty(impl_,
utils::minifiStringView(prop.name), [](void* data, const MinifiSslData*
minifi_ssl_data) {
+ if (const auto status =
minifi_process_context_get_ssl_data_from_property(impl_,
utils::minifiStringView(prop.name), [](void* data, const minifi_ssl_data*
minifi_ssl_data) {
auto* my_ssl_data = static_cast<utils::net::SslData*>(data);
Review Comment:
https://github.com/apache/nifi-minifi-cpp/pull/2205/changes/dfacebe8c17298a2e4550c33f99c0ddad75d3231#diff-b52e4956083b5dcb52bf24c915699f351d6db2954e30b2f8f123cda138834cdeR86-R88
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
