martinzink commented on code in PR #2205:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2205#discussion_r3492359399
##########
libminifi/include/RemoteProcessGroupPort.h:
##########
@@ -105,11 +105,6 @@ class RemoteProcessGroupPort : public core::ProcessorImpl {
void setDirection(sitetosite::TransferDirection direction) {
direction_ = direction;
- if (direction_ == sitetosite::TransferDirection::RECEIVE) {
- setTriggerWhenEmpty(true);
- } else {
- setTriggerWhenEmpty(false);
- }
}
Review Comment:
good idea, ive even made the direction const so it cannot be changed after
ctor
https://github.com/apache/nifi-minifi-cpp/pull/2205/changes/af940b4217fa05b17a4026b6140b0fc51349c7aa#diff-3947105bdabd548d7f24b1c1b75a32d2001ee1f421992d83add17a4d6511d889R182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
