szaszm commented on code in PR #2205:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2205#discussion_r3530029864
##########
libminifi/test/integration/extension-verification-test/CApiExtension.cpp:
##########
@@ -40,17 +40,17 @@ class DummyCProcessor : public
minifi::api::core::ProcessorImpl {
static constexpr bool IsSingleThreaded = true;
};
-CEXTENSIONAPI const uint32_t MinifiApiVersion = MINIFI_TEST_API_VERSION;
+CEXTENSIONAPI const uint32_t minifi_api_version = MINIFI_TEST_API_VERSION;
Review Comment:
I'm thinking maybe this symbol should be all caps, because it's different
from everything else, and relatively constant, but I'm not sure yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
