lordgamez opened a new pull request, #2261: URL: https://github.com/apache/nifi-minifi-cpp/pull/2261
Claude Code found a potential memory leak when allocating node id in OPC processors. In case of `translateBrowsePathsToNodeIdsRequest` calls or any other cases where `UA_NodeId` is allocated, and uses a node id type that is heap allocated like a string nodeid, the owner's responsibility is to free that node id using `UA_NodeId_clear` call when the id is no longer in use. This commit adds a RAII wrapper for the `UA_NodeId` to mitigate this issue. The PR additionally renames the OPC files to align with the filename conventions of the repository. https://issues.apache.org/jira/browse/MINIFICPP-2900 ----------- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
