szaszm commented on code in PR #2261:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2261#discussion_r4016019988
##########
extensions/opc/include/OPCCommon.h:
##########
@@ -58,6 +58,43 @@ enum class OPCNodeDataType{
String
};
+// RAII owner for a UA_NodeId that calls UA_NodeId_clear to free node id
allocation
+class NodeId {
+ public:
+ NodeId() = default;
+ explicit NodeId(UA_NodeId id) noexcept : id_(id) {} // takes ownership of
an already-built node id
+ NodeId(const NodeId&) = delete;
+ NodeId& operator=(const NodeId&) = delete;
+ NodeId(NodeId&& other) noexcept : id_(other.id_) { other.id_ =
UA_NODEID_NULL; }
+ NodeId& operator=(NodeId&& other) noexcept {
+ if (this != &other) {
+ UA_NodeId_clear(&id_);
+ id_ = other.id_;
+ other.id_ = UA_NODEID_NULL;
+ }
+ return *this;
+ }
+ ~NodeId() noexcept { UA_NodeId_clear(&id_); }
+
+ static NodeId copyOf(const UA_NodeId& id) {
+ NodeId result;
+ UA_NodeId_copy(&id, &result.id_);
+ return result;
+ }
+
+ operator const UA_NodeId&() const noexcept { return id_; } //
NOLINT(google-explicit-constructor) implicit passthrough to the C API is
intended
+ [[nodiscard]] const UA_NodeId& get() const noexcept { return id_; }
+
+ // Returns a pointer to the (cleared) node id for an open62541 out-parameter
to write a freshly created node id into.
+ UA_NodeId* receive() noexcept {
+ UA_NodeId_clear(&id_);
+ return &id_;
+ }
Review Comment:
what if the write fails, do we handle those error cases correctly? wouldn't
it be cleaner to keep the out param local to the call, then wrap the result
manually in this NodeId wrapper, and move-assign to existing wrapper objects as
necessary?
##########
extensions/opc/include/OPCCommon.h:
##########
@@ -58,6 +58,43 @@ enum class OPCNodeDataType{
String
};
+// RAII owner for a UA_NodeId that calls UA_NodeId_clear to free node id
allocation
+class NodeId {
+ public:
+ NodeId() = default;
+ explicit NodeId(UA_NodeId id) noexcept : id_(id) {} // takes ownership of
an already-built node id
+ NodeId(const NodeId&) = delete;
+ NodeId& operator=(const NodeId&) = delete;
+ NodeId(NodeId&& other) noexcept : id_(other.id_) { other.id_ =
UA_NODEID_NULL; }
+ NodeId& operator=(NodeId&& other) noexcept {
+ if (this != &other) {
+ UA_NodeId_clear(&id_);
+ id_ = other.id_;
+ other.id_ = UA_NODEID_NULL;
+ }
+ return *this;
+ }
+ ~NodeId() noexcept { UA_NodeId_clear(&id_); }
Review Comment:
Is this valid for UA_NODEID_NULL or already cleared objects?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
