lordgamez commented on PR #2261: URL: https://github.com/apache/nifi-minifi-cpp/pull/2261#issuecomment-5637600429
> Can you have Claude Code do a thorough review too, before we waste human reviewer time on trivial issues? It's giving better results than Copilot usually does. > > The first things I've noticed: > > * No gsl::owner annotation when taking ownership of the node id > > * Destructor should be noexcept I ran Claude Code to review the commit, but it did not find any issues that was relevant to the commit and needs to be addressed. I added noexcept to the destructor in https://github.com/apache/nifi-minifi-cpp/pull/2261/commits/7cbb097173228045e2e26afb43104153e138a5ee `gsl::owner` is not applicable here as the UA_NodeId struct itself is stack allocated and the heap allocation depends on the actual type in its union member. The ownership logic is implemented in the UA_* types. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
